Add documentation for kubernetes_deployment resource #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
reviewed
Oct 26, 2018
|
|
||
| The following arguments are supported: | ||
|
|
||
| * `metadata` - (Required) Standard deployment's metadata. More info: https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#metadata |
There was a problem hiding this comment.
Instead of having the raw URL's here, I'd just link this as like
[Kubernetes reference](https://....)Or something, in each of these cases.
There was a problem hiding this comment.
good point! let me change that.
There was a problem hiding this comment.
FYI, this is the format throughout all the provider docs. I'll switch it everywhere.
There was a problem hiding this comment.
@paultyng How about now?
|
@paultyng broken links should be fixed now. |
paultyng
approved these changes
Oct 27, 2018
alexsomesan
added a commit
that referenced
this pull request
Nov 5, 2018
* Add documentation for kubernetes_deployment resource * Docs - convert verbatim URLs to hyperlinks. * Fix broken links
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community PR that contributed the Deployments resource was missing it's corresponding documentation.
This change addresses that by adding the relevant documentation.
@terraform-providers/ecosystem