Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify delete operation for resources #1914

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Modify delete operation for resources #1914

merged 3 commits into from
Dec 1, 2022

Conversation

sheneska
Copy link
Contributor

@sheneska sheneska commented Nov 28, 2022

This PR adds a check to the delete function of the kubernetes_priority_class, kubernetes_replication_controller, kuberentes_resource_quota, kubernetes_role, kubernetes_role_binding, kubernetes_secret, kuberntes_service, kubernetes_service_account, kubernetes_stateful_set, kuberentes_storage_class, kubernetes_validating_webhook_configuration, and kubernetes_validating_webhook_configuration.

Fixes #1822

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@sheneska sheneska requested a review from jrhouston November 28, 2022 16:58
@arybolovlev arybolovlev requested a review from a team as a code owner November 30, 2022 13:15
@github-actions github-actions bot added size/M and removed size/S labels Nov 30, 2022
@jrhouston jrhouston merged commit f0c9161 into main Dec 1, 2022
@jrhouston jrhouston deleted the idempotent-delete-3 branch December 1, 2022 16:39
@sherifabdlnaby
Copy link
Contributor

We had a case and were happy to see this fix, but unfortunately, PersistentVoumes wasn't on the list.

@sherifabdlnaby sherifabdlnaby mentioned this pull request Dec 12, 2022
2 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destroy operations do not seem to be idempotent
4 participants