Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restmapper cache #1508

Merged
merged 5 commits into from
Nov 29, 2021
Merged

Restmapper cache #1508

merged 5 commits into from
Nov 29, 2021

Conversation

alexsomesan
Copy link
Member

Description

  • Update client-go to v0.21.7
  • Used the cached version of the RESTMapper client.
  • Don't repeat reading the OpenAPI spec document from the API after each apply.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Before:

Apply complete! Resources: 45 added, 0 changed, 0 destroyed.
terraform apply -auto-approve  111.39s user 3.13s system 67% cpu 2:50.68 total
After:

Apply complete! Resources: 45 added, 0 changed, 0 destroyed.
terraform apply -auto-approve  78.20s user 2.68s system 88% cpu 1:31.45 total

Release Note

Release note for CHANGELOG:

* improve performance for the "kubernetes_manifest" resource.

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan marked this pull request as ready for review November 23, 2021 17:02
@alexsomesan alexsomesan merged commit 1eccf9e into main Nov 29, 2021
@alexsomesan alexsomesan deleted the restmapper-cache branch November 29, 2021 18:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants