Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes post v2.4.0 #1345

Merged
merged 6 commits into from
Aug 3, 2021
Merged

Some fixes post v2.4.0 #1345

merged 6 commits into from
Aug 3, 2021

Conversation

alexsomesan
Copy link
Member

@alexsomesan alexsomesan commented Aug 3, 2021

Description

This change addresses some issues that made their way into release v2.4.0:

  • delays checking the minimum version of Terraform in the manifest resource until after ConfigureProvider
  • documents the minimum Terraform version for manifest resources
  • aligns environment variable names used to set the feature gate flag for kubernetes_manifest
  • fixes a dead link in the documentation

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

BUG FIXES:

* restores compatibility with Terraform versions lower than 0.14.8 (#1341)

References

Fixes #1341

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

manifest/provider/configure.go Outdated Show resolved Hide resolved
website/docs/r/manifest.html.markdown Outdated Show resolved Hide resolved

* This resource uses [Server-side Apply](https://kubernetes.io/docs/reference/using-api/server-side-apply/) to carry out apply operations. A minimum Kubernetes version of 1.16.x is required, but versions 1.17+ are strongly recommended as the SSA implementation in Kubernetes 1.16.x is incomplete and unstable.

* A minimum Terraform version of 0.14.8 is required to use this resource.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment is not relevant

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a lot of other constraints relating to terraform 0.14 on this branch. Is this PR complete to work with RF 0.12 and 0.13 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think the minimum supported Kubernetes version is not important to communicate to users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which constraints do you suspect might prevent it from working with TF 0.12 / 0.13?

@alexsomesan alexsomesan merged commit 2f81421 into main Aug 3, 2021
@alexsomesan alexsomesan deleted the delay-tf-ver-check branch August 3, 2021 14:42
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform 0.12 not supported with release 2.4.0
3 participants