Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/pod_spec - service account name default value #1235

Closed

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Apr 15, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccKubernetesPod_basic (44.12s)

Release Note

Release note for CHANGELOG:

resource_kubernetes_pod - `service_account_name` defaults to `default`
resource_kubernetes_deployment - `service_account_name` defaults to `default`
resource_kubernetes_statefulset - `service_account_name` defaults to `default`
resource_kubernetes_daemonset - `service_account_name` defaults to `default`

References

Closes #1089

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@DrFaust92 DrFaust92 changed the title r/pod - service account name default value r/pod_spec - service account name default value Apr 15, 2021
@dak1n1 dak1n1 added the acknowledged Issue has undergone initial review and is in our work queue. label Apr 26, 2021
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from cc85109 to 0d35b01 Compare May 16, 2021 15:59
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 0d35b01 to 05aa846 Compare May 28, 2021 10:52
@DrFaust92
Copy link
Contributor Author

Rebased and resolved conflicts

@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 05aa846 to 26057ac Compare August 15, 2021 14:41
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 26057ac to 0e1cb59 Compare October 6, 2021 07:20
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 0e1cb59 to 7d99dcb Compare February 17, 2022 20:03
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 7d99dcb to 9d0e93e Compare March 12, 2022 22:18
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from 9d0e93e to ca91f07 Compare April 12, 2022 21:25
@DrFaust92 DrFaust92 force-pushed the r/pod_service_account_default branch from ca91f07 to bc408c9 Compare April 22, 2022 10:38
@github-actions github-actions bot added the stale label Oct 24, 2023
@DrFaust92 DrFaust92 closed this Nov 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Issue has undergone initial review and is in our work queue. documentation size/XS stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Account cannot be removed from PodSpec
3 participants