Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down golang.org/x/sys working version to fix builds for macOS #1046

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

alexsomesan
Copy link
Member

Description

Fixes build on macOS as reported in #1045

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

Pending TC run

Release Note

Release note for CHANGELOG:

NONE

References

moby/term#15

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@alexsomesan alexsomesan requested a review from a team October 26, 2020 20:52
@alexsomesan
Copy link
Member Author

CI shows no regressions.

@alexsomesan alexsomesan merged commit 86e9719 into master Oct 27, 2020
@alexsomesan alexsomesan deleted the pin-go-x-sys branch October 27, 2020 11:45
@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants