Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Add more test coverage of basic resources #219

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

jrhouston
Copy link
Contributor

This PR adds acceptance tests for DaemonSet, StatefulSet, Job, CronJob, Secret, Namespace, and HPA.

Description

Release Note

Release note for CHANGELOG:

NONE

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/XL labels May 27, 2021
@jrhouston
Copy link
Contributor Author

jrhouston commented May 27, 2021

GitHub actions failing at the moment because of this: juliangruber/read-file-action#12

edit: ✅ working now

@jrhouston jrhouston requested a review from a team May 27, 2021 16:45
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mooaar tests! 😄
Looks good!

@alexsomesan alexsomesan merged commit b73b3bf into master Jun 2, 2021
@alexsomesan alexsomesan deleted the basic-resource-test-coverage branch June 2, 2021 17:22
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants