Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show manifest when creating release #903

Merged
merged 12 commits into from
Jul 19, 2022

Conversation

BBBmau
Copy link
Contributor

@BBBmau BBBmau commented Jun 29, 2022

Description

Manifest will now be outputted when running terraform plan before creating a release. Before the manifest would only show when updating a value

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

* Show Manifest when creating release

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@BBBmau BBBmau requested a review from jrhouston June 29, 2022 23:51
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding this, a few things to address!

CHANGELOG.md Outdated Show resolved Hide resolved
helm/resource_release.go Outdated Show resolved Hide resolved
helm/resource_release.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/M and removed size/S labels Jul 8, 2022
@BBBmau
Copy link
Contributor Author

BBBmau commented Jul 8, 2022

Saw that the changelog-entry feature was missing the ability to input the PR Number, went along and added it into this same PR in order to have the 903.txt inside the .changelog folder.

When specifying the PR Number, user must export PR_NUM= before running make changelog-entry

@BBBmau BBBmau requested a review from jrhouston July 8, 2022 15:12
GNUmakefile Outdated Show resolved Hide resolved
@jrhouston jrhouston changed the title Show manifest when creating release TK-626 Show manifest when creating release Jul 14, 2022
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @BBBmau!

@jrhouston jrhouston merged commit 94ae66a into main Jul 19, 2022
@jrhouston jrhouston deleted the show-manifest-after-creating-release branch July 19, 2022 03:26
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants