Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty credentials check #659

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

jrhouston
Copy link
Contributor

Description

This PR removes the check function that generates an error when the kubernetes provider block doesn't seem to have been configured. We are hoping this should remedy some of the issues seen in #647 and #52. The downside of this is you get a confusing error message from client-go if you don't configure the provider block correctly.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

Remove empty credentials check for kubernetes block 

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/S label Jan 13, 2021
@jrhouston jrhouston requested a review from a team January 13, 2021 16:30
Copy link
Contributor

@dak1n1 dak1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really liked this check! 😢 But maybe we'll bring it back later, with some additions. I'm planning to test it out in the Kubernetes provider (post 2.0 release) and then cover all the edge cases I can find. So some day, it might be back... Thanks for this PR!

@jrhouston
Copy link
Contributor Author

Yeah I am hoping we can figure out something useful with warnings rather than errors that doesn't trigger the progressive apply issue.

@jrhouston jrhouston merged commit c38916e into master Jan 15, 2021
@jrhouston jrhouston deleted the remove-empty-creds-check branch January 15, 2021 20:21
@ghost
Copy link

ghost commented Feb 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants