Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max_history default value to 10 #1525

Closed
wants to merge 1 commit into from
Closed

Update max_history default value to 10 #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/resources/release.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ A Chart is a Helm package. It contains all of the resource definitions necessary
- `force_update` (Boolean) Force resource update through delete/recreate if needed. Defaults to `false`.
- `keyring` (String) Location of public keys used for verification. Used only if `verify` is true. Defaults to `/.gnupg/pubring.gpg` in the location set by `home`.
- `lint` (Boolean) Run helm lint when planning. Defaults to `false`.
- `max_history` (Number) Limit the maximum number of revisions saved per release. Use 0 for no limit. Defaults to 0 (no limit).
- `max_history` (Number) Limit the maximum number of revisions saved per release. Use 0 for no limit. Defaults to 10.
- `namespace` (String) Namespace to install the release into. Defaults to `default`.
- `pass_credentials` (Boolean) Pass credentials to all domains. Defaults to `false`.
- `postrender` (Block List, Max: 1) Postrender command configuration. (see [below for nested schema](#nestedblock--postrender))
Expand Down
2 changes: 1 addition & 1 deletion helm/resource_release.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ var defaultAttributes = map[string]interface{}{
"reset_values": false,
"reuse_values": false,
"recreate_pods": false,
"max_history": 0,
"max_history": 10,
"skip_crds": false,
"cleanup_on_fail": false,
"dependency_update": false,
Expand Down
2 changes: 1 addition & 1 deletion helm/resource_release_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ func TestAccResourceRelease_import(t *testing.T) {
resource.TestCheckResourceAttr("helm_release.imported", "reset_values", "false"),
resource.TestCheckResourceAttr("helm_release.imported", "reuse_values", "false"),
resource.TestCheckResourceAttr("helm_release.imported", "recreate_pods", "false"),
resource.TestCheckResourceAttr("helm_release.imported", "max_history", "0"),
resource.TestCheckResourceAttr("helm_release.imported", "max_history", "10"),
resource.TestCheckResourceAttr("helm_release.imported", "skip_crds", "false"),
resource.TestCheckResourceAttr("helm_release.imported", "cleanup_on_fail", "false"),
resource.TestCheckResourceAttr("helm_release.imported", "dependency_update", "false"),
Expand Down
Loading