Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Rename struct fields in HelmReleaseModel to CamelCase #1479

Conversation

JaylonmcShan03
Copy link
Contributor

Description

Refactor: Rename struct fields in HelmReleaseModel to CamelCase

  • Changed field names from snake_case to CamelCase.
  • Updated the related structs > SetResourceModel, SetListResourceModel, SetSensitiveResourceModel, and PostrenderModel to follow CamelCase

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Timeout types.Int64 `tfsdk:"timeout"`
DisableWebhooks types.Bool `tfsdk:"disable_webhooks"`
DisableCrdHooks types.Bool `tfsdk:"disable_crd_hooks"`
Reset_Values types.Bool `tfsdk:"reset_values"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll want to have it be done on Reset_values also

Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorting it alphabetically was a big improvement. thanks!

@JaylonmcShan03 JaylonmcShan03 force-pushed the refactor/helmreleasemodel-camelcase-field-renaming branch from b1f16dc to 471e701 Compare September 5, 2024 14:18
@JaylonmcShan03 JaylonmcShan03 merged commit 27f9e7a into helm-framework Sep 5, 2024
2 checks passed
@JaylonmcShan03 JaylonmcShan03 deleted the refactor/helmreleasemodel-camelcase-field-renaming branch September 5, 2024 14:19
JaylonmcShan03 added a commit that referenced this pull request Oct 8, 2024
* Refactor: Rename struct fields in HelmReleaseModel to CamelCase

* Fixing overlooked field, and making the struct names in alphabetical order
jrhouston pushed a commit that referenced this pull request Jan 7, 2025
* Refactor: Rename struct fields in HelmReleaseModel to CamelCase

* Fixing overlooked field, and making the struct names in alphabetical order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants