Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Change model references from 'd' to 'model' for consistency #1478

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Refactor: Change model references from 'd' to 'model' for consistency #1478

merged 1 commit into from
Sep 5, 2024

Conversation

JaylonmcShan03
Copy link
Contributor

Description

This PR refactors the code to change model references from d to model to improve readability and consistency.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@JaylonmcShan03 JaylonmcShan03 requested a review from a team as a code owner September 4, 2024 14:41
@github-actions github-actions bot added size/M and removed size/S labels Sep 4, 2024
BBBmau
BBBmau approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better, thanks!

@JaylonmcShan03 JaylonmcShan03 merged commit af0c028 into helm-framework Sep 5, 2024
3 checks passed
@JaylonmcShan03 JaylonmcShan03 deleted the refactor/change-d-to-model branch September 5, 2024 13:55
JaylonmcShan03 added a commit that referenced this pull request Oct 8, 2024
@JaylonmcShan03
Refactor: Change model references from 'd' to 'model' for consistency (…
21df1ea 
…#1478)
jrhouston pushed a commit that referenced this pull request Jan 7, 2025
@JaylonmcShan03 @jrhouston
Refactor: Change model references from 'd' to 'model' for consistency (…
0585e0b 
…#1478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees
No one assigned
Labels
plugin-framework size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaylonmcShan03 @BBBmau