adding new resource dns resource record set #8835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit - adding new resource dns resource record set * ignore_read set for managed_zone as API not returning it * import_format and update_verb added * handwritten test cases added * handwritten test cases added, supressdiff func added * fixed value attribute 'kind' removed from schema * test name modified per PR comments * legacy name attribute added * removed extra line * cleaned up the entries made on other resource accidentally * excluded resource for inspec * old handwritten resource removed from provider, test cases updated as per new resources, examples updated and duplicate tests deleted * removed commented line * test case inputs reverted to old upper case values as per PR comments * suppress diff function modified to handle different cases, deleted old resource file and encoder * attribute eliminated as its not required in API request * indent corrected * beta only unit test case added and file extension changed * input flags added to the fields * resource_record_set resource added to GA as API supports it now * removed the generated resource entries added while added during merge conflict * excluded the resource for Ansible * Import steps added to tests as per PR comments Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)
fixes #7981
Derived from GoogleCloudPlatform/magic-modules#4361