Add new resource google_folder_organization_policy #747
Conversation
rosbo
force-pushed
the
folder-org-policy
branch
2 times, most recently
from
45790d0 to
dc03279
Compare
rosbo
force-pushed
the
folder-org-policy
branch
from
dc03279 to
ff7d965
Compare
|
Rebased with the latest changes. |
| } | ||
|
|
||
| if policy.ListPolicy.AllValues != policyType { | ||
| return fmt.Errorf("Expected the list policy to '%s' all values, got '%s'", policyType, policy.ListPolicy.AllValues) |
There was a problem hiding this comment.
I'm not totally sure what this is supposed to say, can you reword it?
There was a problem hiding this comment.
Wooahh. I don't even know what I meant. Reworded.
FYI, policyType is either ALLOW or DENY.
| func testAccGoogleFolderOrganizationPolicy_boolean(org string, enforced bool) string { | ||
| return fmt.Sprintf(` | ||
| resource "google_folder" "orgpolicy" { | ||
| display_name = "%s" |
There was a problem hiding this comment.
nit: indentation isn't consistent between this block and the next
| enforced = %t | ||
| } | ||
| } | ||
| `, acctest.RandomWithPrefix("tf-test"), "organizations/"+org, enforced) |
There was a problem hiding this comment.
Even though you can rename a folder, let's use a consistent name per-test (rather than per-test-step) so we guarantee we're testing only the org policy behavior.
* Add new resource google_folder_organization_policy * Add documentation
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Fixes #414