Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for diffs in allowed ranges set #6411

Conversation

modular-magician
Copy link
Collaborator

Checking the parent object for HasChange produces incorrect results.

No changes as this has not been released yet

See hashicorp/terraform-plugin-sdk#98

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#3529

* Check for diffs in allowed ranges set, checking in parent object produces incorrect changes due to sets internal representation

* Add comment

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label May 18, 2020
@modular-magician modular-magician merged commit 52263cf into hashicorp:master May 18, 2020
@ghost
Copy link

ghost commented Jun 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 18, 2020
@modular-magician modular-magician deleted the downstream-pr-90360f9400628375e4fac82573a3ecbc2acd8a64 branch November 17, 2024 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant