Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] issue #2909, IAM Condition #4029

Closed
wants to merge 2 commits into from
Closed

Conversation

Cidan
Copy link
Contributor

@Cidan Cidan commented Jul 15, 2019

WIP, please do not merge, no tests yet.

@ghost ghost added the size/s label Jul 15, 2019
@Cidan
Copy link
Contributor Author

Cidan commented Jul 15, 2019

Adds conditional IAM support to fix #2909 as noted in https://cloud.google.com/iam/docs/conditions-overview

@danawillow
Copy link
Contributor

Hi @Cidan, just letting you know that I plan to work on this feature. You're welcome to continue if you want, but I have a design doc I'm working on to make sure we cover all cases correctly. Ping me internally if you have more questions :)

@nauris-sadovskis
Copy link

Hi @danawillow, @Cidan - any new information on this?

@danawillow
Copy link
Contributor

Yup, getting pretty close to having code ready! I'm going to go ahead and close this PR so we can keep conversation in one place for now (#2909)

@danawillow danawillow closed this Sep 23, 2019
@ghost
Copy link

ghost commented Oct 24, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants