-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the correct default for UseLegacySQL #373
Conversation
Support Bigquery Views
Hey there @jimmy-btn, I'm looking at this PR (sorry for the delay!) and it seems... a bit odd. There seem to be a lot of commits to change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs commit squash and more info on why the change is being made.
Hey @jimmy-btn, without more info on why these changes are being made, I'm going to go ahead and close this PR. But I'm certainly happy to reopen and move forward with it, just reply here and let us know. Thanks! |
Hi Paddy - my apologies, I missed your original comment!
The commit history mess is my bad; let me clean that up and get this PR
into a better shape.
This change is motivated by an unintentional bug I introduced when adding
View support to BigQuery Tables.
…On Tue, Nov 7, 2017 at 5:57 PM, Paddy ***@***.***> wrote:
Hey @jimmy-btn <https://github.com/jimmy-btn>, without more info on why
these changes are being made, I'm going to go ahead and close this PR. But
I'm certainly happy to reopen and move forward with it, just reply here and
let us know. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#373 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Acsi_Z57HpvqJMqCEopsbBotUzUIZaDDks5s0OBmgaJpZM4PJE0W>
.
|
No problem at all. Let's reopen this then, and we can move it forward. 👍 |
Hey Paddy - I somehow got my workspace into a terrible state. Rather than
drag that mess into the repo, I created a clean PR here:
#724
Let's close this one out and follow up there.
…On Tue, Nov 7, 2017 at 6:41 PM, Paddy ***@***.***> wrote:
Reopened #373
<#373>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#373 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Acsi_dig3EKK0VXA8zX7M4mGqnnDXH-uks5s0OqYgaJpZM4PJE0W>
.
|
<!-- This change is generated by MagicModules. --> /cc @rileykarson
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
No description provided.