Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct default for UseLegacySQL #373

Closed
wants to merge 9 commits into from
Closed

Set the correct default for UseLegacySQL #373

wants to merge 9 commits into from

Conversation

jimmy-btn
Copy link
Contributor

No description provided.

@paddycarver
Copy link
Contributor

Hey there @jimmy-btn, I'm looking at this PR (sorry for the delay!) and it seems... a bit odd. There seem to be a lot of commits to change Default to true. Could we squash the commits down? And can you provide any insight on why the Default should be true? Thanks!

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs commit squash and more info on why the change is being made.

@paddycarver
Copy link
Contributor

Hey @jimmy-btn, without more info on why these changes are being made, I'm going to go ahead and close this PR. But I'm certainly happy to reopen and move forward with it, just reply here and let us know. Thanks!

@paddycarver paddycarver closed this Nov 7, 2017
@jimmy-btn
Copy link
Contributor Author

jimmy-btn commented Nov 7, 2017 via email

@paddycarver
Copy link
Contributor

No problem at all. Let's reopen this then, and we can move it forward. 👍

@jimmy-btn
Copy link
Contributor Author

jimmy-btn commented Nov 10, 2017 via email

@paddycarver paddycarver closed this Dec 7, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants