Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase IAM custom role length validation to match API. #3660

Merged
merged 1 commit into from
May 20, 2019

Conversation

rremer
Copy link
Contributor

@rremer rremer commented May 20, 2019

This fixes #3658 @pdecat

I'm still digging for the doc source which generates this misinformation: https://cloud.google.com/iam/docs/understanding-custom-roles#naming_the_role

@ghost ghost added the size/xs label May 20, 2019
@rremer
Copy link
Contributor Author

rremer commented May 20, 2019

Happy to contribute the doc fix too, but was unable to locate the source for it. Left feedback on that page instead to rectify the naming constraints.

google/validation.go Outdated Show resolved Hide resolved
@rremer rremer force-pushed the iam_custom_role_64 branch from 7970184 to cc01c82 Compare May 20, 2019 17:38
@hrgui
Copy link

hrgui commented May 21, 2019

I had the same issues that @pdecat had, but then when I went to the GCP UI, I saw the following:

Screen Shot 2019-05-21 at 10 58 46 AM
The validation in the UI made me think that it's not possible to create IAM roles greater than 30 characters.

There seems to be a disconnect from what the UI is saying and what the API is saying for this validation. I think we should either:

update the UI to reflect the actual limit and the docs itself, or
we should update the API and this TF provider.

@danawillow
Copy link
Contributor

Hi @hrgui, each of those components is maintained by a different team, but I went ahead and filed bugs internally so hopefully we'll see an update at some point.

@danawillow
Copy link
Contributor

@rremer
Copy link
Contributor Author

rremer commented May 23, 2019

For the record, is there a repo somewhere we could have made the change to or are those doc sources internal?

@danawillow
Copy link
Contributor

It's internal, thanks for trying though!

@ghost
Copy link

ghost commented Jun 20, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

role_id with more than 30 characters doesn't match regexp
4 participants