-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase IAM custom role length validation to match API. #3660
Conversation
Happy to contribute the doc fix too, but was unable to locate the source for it. Left feedback on that page instead to rectify the naming constraints. |
7970184
to
cc01c82
Compare
I had the same issues that @pdecat had, but then when I went to the GCP UI, I saw the following:
There seems to be a disconnect from what the UI is saying and what the API is saying for this validation. I think we should either: update the UI to reflect the actual limit and the docs itself, or |
Hi @hrgui, each of those components is maintained by a different team, but I went ahead and filed bugs internally so hopefully we'll see an update at some point. |
GCP docs have been updated: https://cloud.google.com/iam/docs/understanding-custom-roles#naming_the_role 🎉 |
For the record, is there a repo somewhere we could have made the change to or are those doc sources internal? |
It's internal, thanks for trying though! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
This fixes #3658 @pdecat
I'm still digging for the doc source which generates this misinformation: https://cloud.google.com/iam/docs/understanding-custom-roles#naming_the_role