Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write entire backend service resource when updating #364

Conversation

selmanj
Copy link
Contributor

@selmanj selmanj commented Aug 28, 2017

Also update the default value for connection_draining_timeout_sec to
match the default used by GCP

Fixes #348

Also update the default value for connection_draining_timeout_sec to
match the default used by GCP
@selmanj selmanj requested a review from paddycarver August 28, 2017 18:10
@rosbo
Copy link
Contributor

rosbo commented Sep 6, 2017

TF_ACC=1 go test ./google -v -run TestAccComputeBackendService_ -timeout 120m
=== RUN TestAccComputeBackendService_importBasic
--- PASS: TestAccComputeBackendService_importBasic (45.14s)
=== RUN TestAccComputeBackendService_basic
--- PASS: TestAccComputeBackendService_basic (67.49s)
=== RUN TestAccComputeBackendService_withBackend
--- PASS: TestAccComputeBackendService_withBackend (92.82s)
=== RUN TestAccComputeBackendService_withBackendAndUpdate
--- PASS: TestAccComputeBackendService_withBackendAndUpdate (104.59s)
=== RUN TestAccComputeBackendService_updatePreservesOptionalParameters
--- PASS: TestAccComputeBackendService_updatePreservesOptionalParameters (56.53s)
=== RUN TestAccComputeBackendService_withConnectionDraining
--- PASS: TestAccComputeBackendService_withConnectionDraining (44.51s)
=== RUN TestAccComputeBackendService_withConnectionDrainingAndUpdate
--- PASS: TestAccComputeBackendService_withConnectionDrainingAndUpdate (56.28s)
=== RUN TestAccComputeBackendService_withHttpsHealthCheck
--- PASS: TestAccComputeBackendService_withHttpsHealthCheck (44.11s)
=== RUN TestAccComputeBackendService_withCDNEnabled
--- PASS: TestAccComputeBackendService_withCDNEnabled (44.33s)
=== RUN TestAccComputeBackendService_withSessionAffinity
--- PASS: TestAccComputeBackendService_withSessionAffinity (56.59s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 612.528s

@selmanj selmanj merged commit 5cd3e1e into hashicorp:master Sep 7, 2017
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
Also update the default value for connection_draining_timeout_sec to
match the default used by GCP
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

session affinity no longer set on backend services
2 participants