transport replaceVars url escape values #3347
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2895
According to https://cloud.google.com/storage/docs/json_api/#encoding URI paths parts are supposed to be encoded.
For example in
google_storage_object_access_control
if the object name contains a/
, the request will fail with:To my knowledge,
replaceVars()
is specifically for replacing variables in URLs (as for the name of the parameter "linkTmpl"), so I'm assuming this would work globally.