Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google compute instance doc updates #3115

Merged

Conversation

conorgil
Copy link
Contributor

Documentation updates based on first interaction with the compute_instance resource.

  • Cleans up sentence structure for access_config field.
  • Explains relationship between scheduling. preemptible and scheduling.automatic_retry fields and lists the default value of each field.

conorgil and others added 3 commits February 15, 2019 19:10
Attempting to create an instance with:

```
scheduling {
  preemptible = true
}
```

yields the following error (whitespace reformatted):

```
Error: Error applying plan:

1 error(s) occurred:

* google_compute_instance.test: 1 error(s) occurred:

* google_compute_instance.test: Error creating instance: googleapi: Error 400:
                                Invalid value for field
                                'resource.scheduling.preemptible': 'true'.
                                Scheduling must have preemptible be false when
                                AutomaticRestart is true., invalid
```

Documenting the default values for each field and the relationship
between then will help users avoid this error.
Copy link
Collaborator

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @conorgil!

network (e.g. via tunnel or because it is running on another cloud instance
on that network). This block can be repeated multiple times. Structure
documented below.
is not accessible from the Internet. If omitted, ssh provisioners will not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@rileykarson rileykarson merged commit 82e6e48 into hashicorp:master Mar 7, 2019
@ghost
Copy link

ghost commented Apr 7, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants