Fix vendor directory. #2932
Merged
Fix vendor directory. #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks govendor. I'll figure it out. |
|
Oh, haha, travis is on go 1.11.0. |
|
That ought to do it... |
rileykarson
approved these changes
Jan 25, 2019
rileykarson
added a commit
that referenced
this pull request
Feb 1, 2019
Adding `.x` to Travis means use the latest minor version according to its docs. I didn't update the "Requirements" header because this is just because of Go Modules; see #2932 for why. Since it's just a development change, it doesn't impact _using_ the provider. Although, out of curiosity- is that header for development? Or is there a real requirement to have Go installed to use Terraform providers?
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go 1.11 and forward until go 1.11.4, checksums were calculated incorrectly if a module contained symlinks. In go 1.11.4, the go team made a breaking change that requires people using go modules to delete their vendor directory and recreate it. It also requires that everyone working on a project be either pre-1.11.4 or post 1.11.4. The magician is on 1.11.5, but the rest of us are probably on 1.11 or 1.11.1. Whoops! I updated go and did the go vendor again. Here's the result. Make sure to update your go version!
Caused by golang/go#27093.