Add gometalinter #2627
Merged
Add gometalinter #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
approved these changes
Dec 11, 2018
rileykarson
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this pull request
Dec 12, 2018
paddycarver
pushed a commit
that referenced
this pull request
Dec 14, 2018
Parallel to hashicorp/terraform-provider-azurerm#2116 We need to run `gofmt -s` to switch over to the `gofmt` rule, and MM is going to complicate that. Once `1.20.0` is done, I'll run that command on flat MM files & add a `gofmt -s` step to MM generation (goimports does gofmt but doesn't do the s flag for silly reasons). I'll duplicate this over to tpgb once this PR is merged.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
Parallel to hashicorp/terraform-provider-azurerm#2116 We need to run `gofmt -s` to switch over to the `gofmt` rule, and MM is going to complicate that. Once `1.20.0` is done, I'll run that command on flat MM files & add a `gofmt -s` step to MM generation (goimports does gofmt but doesn't do the s flag for silly reasons). I'll duplicate this over to tpgb once this PR is merged.
nat-henderson
pushed a commit
that referenced
this pull request
Dec 21, 2018
Parallel to hashicorp/terraform-provider-azurerm#2116 We need to run `gofmt -s` to switch over to the `gofmt` rule, and MM is going to complicate that. Once `1.20.0` is done, I'll run that command on flat MM files & add a `gofmt -s` step to MM generation (goimports does gofmt but doesn't do the s flag for silly reasons). I'll duplicate this over to tpgb once this PR is merged.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel to hashicorp/terraform-provider-azurerm#2116
We need to run
gofmt -sto switch over to thegofmtrule, and MM is going to complicate that. Once1.20.0is done, I'll run that command on flat MM files & add agofmt -sstep to MM generation (goimports does gofmt but doesn't do the s flag for silly reasons).I'll duplicate this over to tpgb once this PR is merged.