Add num local ssds and boot disk types to preemptible worker config #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance somebody could look at this? |
Tests preemptible / secondary worker disks, but doesn't correctly check those disks.
nat-henderson
added a commit
to GoogleCloudPlatform/magic-modules
that referenced
this pull request
Dec 17, 2018
nat-henderson
suggested changes
Dec 17, 2018
|
Thanks for having a look, I've added docs for the changes |
modular-magician
pushed a commit
to GoogleCloudPlatform/magic-modules
that referenced
this pull request
Dec 20, 2018
|
Closing as this was merged in as #2696 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num_local_ssds and boot_disk_type are now honoured so I have added the required changes to pass them through.