Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource_pubsub_topic.go to save project in state #2346

Closed
wants to merge 1 commit into from

Conversation

mingzhaodotname
Copy link

When "project" is not specified in the resource, it is not saved in the state file.

TESTED: make testacc TEST=./google TESTARGS='-run=TestAccPubsubTopic'

@ghost ghost added the size/xs label Oct 26, 2018
danawillow added a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Oct 30, 2018
@danawillow danawillow self-requested a review October 30, 2018 21:49
@mingzhaodotname
Copy link
Author

defer to GoogleCloudPlatform/magic-modules#651

danawillow added a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Nov 13, 2018
modular-magician pushed a commit to modular-magician/terraform-provider-google that referenced this pull request Nov 13, 2018
danawillow pushed a commit that referenced this pull request Nov 13, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
modular-magician pushed a commit to GoogleCloudPlatform/magic-modules that referenced this pull request Nov 13, 2018
nat-henderson pushed a commit that referenced this pull request Dec 4, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
nat-henderson pushed a commit that referenced this pull request Dec 5, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
nat-henderson pushed a commit that referenced this pull request Dec 6, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
nat-henderson pushed a commit that referenced this pull request Dec 13, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
nat-henderson pushed a commit that referenced this pull request Dec 21, 2018
<!-- This change is generated by MagicModules. -->
/cc @danawillow
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Update pubsub topic to read after create, same as TPG hashicorp#2346
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
Update pubsub topic to read after create, same as TPG hashicorp#2346
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant