Add support for auto_healing_policies to google_compute_instance_group_manager. #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
approved these changes
Jul 14, 2017
There was a problem hiding this comment.
make testacc TEST=./google TESTARGS='-run=TestAccInstanceGroupManager_autoHealingPolicies'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccInstanceGroupManager_autoHealingPolicies -timeout 120m
=== RUN TestAccInstanceGroupManager_autoHealingPolicies
--- PASS: TestAccInstanceGroupManager_autoHealingPolicies (221.86s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 221.999s
👍 aside from one nit (feel free to merge after that)
| @@ -646,3 +713,52 @@ func resourceSplitter(resource string) string { | |||
|
|
|||
| return splits[len(splits)-1] | |||
| } | |||
|
|
|||
| func testAccInstanceGroupManager_autoHealingPolicies(template, target, igm, hck string) string { | |||
There was a problem hiding this comment.
Can you put this above the little helper doodad so all the test configs are next to each other?
|
After the change: |
This was referenced Jul 26, 2017
luis-silva
pushed a commit
to luis-silva/terraform-provider-google
that referenced
this pull request
May 21, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
auto_healing_policiestogoogle_compute_instance_group_manager.Walking through the below list of scenarios, I saw the expected results:
CREATE v1REFRESH v1DESTROY v1IMPORT v1UPGRADE v1 to BetaCREATE BetaREFRESH BetaDESTROY BetaIMPORT BetaUPGRADE Beta to v1The weird cases were, as we expected:
UPGRADE v1 to Beta- We can't read at Beta during the pre-apply refresh, so we don't catch out of band changes to Beta fieldsIMPORT Beta- All resources are currently imported atv1UPGRADE Beta to v1- The post-apply read will be performed at Beta and notv1, so the state file will have Beta self links. The next refresh will correct this.