Adding md5auth key to bgp router peer #16923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new field for md5 auth keys in bgp router peer resource * Fixing bugs * Fixing delete and update flows * adding test * Fixing typo in create flow * Fixing typo in test * Fixed diff issue for sensitive field * Making test check for actual value instead of existence * REsponding to PR comments * Adding required tests for multiple bgp peers * Adding depends_on tag for making test deterministic * Fixing test * Fixing update test --------- Co-authored-by: Shivang Dixit <[email protected]> [upstream:6f5723b479b0b3a089301fb6465a29be36175373] Signed-off-by: Modular Magician <[email protected]>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-6f5723b479b0b3a089301fb6465a29be36175373
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding md5Authenctication key field for BGPRouterPeer resource. Related to b/260899743
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9666