Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 5 more importable resources' docs #135

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

rileykarson
Copy link
Collaborator

Update the documentation of 5 more of our importable resources to include Import blocks specifying how to import them.

We now have explicit documentation for:

  • google_compute_forwarding_rule
  • google_compute_global_address
  • google_compute_http_health_check
  • google_compute_instance_group_manager
  • google_compute_instance_template

As in #119, to review:

In each Import block;

  • The fields specified as being used to import a resource should match their names in the schema exactly.
  • The resource address and properties used to perform the example import should be the values used in the example.
  • The properties used to perform an import should not be ambiguous; they should not share the same name, for example.

@stack72
Copy link
Contributor

stack72 commented Jun 21, 2017

LGTM! thanks for this :)

@stack72 stack72 merged commit 54e2c56 into hashicorp:master Jun 21, 2017
pdecat pushed a commit to pdecat/terraform-provider-google that referenced this pull request Jun 29, 2017
Update 5 more importable resources' docs
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this pull request Nov 9, 2018
Update 5 more importable resources' docs
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
add warning about node pools defined in clusters. See TPG hashicorp#1712.
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
add warning about node pools defined in clusters. See TPG hashicorp#1712.
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants