Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metalinter, slightly rework build+test rule #12259

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

rileykarson
Copy link
Collaborator

The metalinter we're using, golangci-lint, is causing more trouble than it's worth in terms of timeout issues. Remove it, and call go vet directly since we're not calling that through a metalinter anymore. We removed it from this repo on #11968 anyways, so this just gets rid of the target the Magician used.

I've gotta remove the Magician bits first, since it'll complain if they go away too soon. So this will stay around for a bit once approved.

@rileykarson rileykarson requested a review from megan07 August 4, 2022 17:33
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants