Remove metalinter, slightly rework build+test rule #12259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metalinter we're using, golangci-lint, is causing more trouble than it's worth in terms of timeout issues. Remove it, and call
go vet
directly since we're not calling that through a metalinter anymore. We removed it from this repo on #11968 anyways, so this just gets rid of the target the Magician used.I've gotta remove the Magician bits first, since it'll complain if they go away too soon. So this will stay around for a bit once approved.