Remove unnecessary StateFunc in compute_target_https_proxy #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danawillow
reviewed
Jan 30, 2018
| ValidateFunc: validateRegexp(sslCertificateRegex), | ||
| StateFunc: toCanonicalSslCertificate, | ||
| Type: schema.TypeString, | ||
| ValidateFunc: validateRegexp(sslCertificateRegex), |
There was a problem hiding this comment.
Can we get rid of this ValidateFunc now since the DiffSuppress will allow setting the resource name?
danawillow
approved these changes
Jan 31, 2018
chrisst
pushed a commit
to chrisst/terraform-provider-google
that referenced
this pull request
Nov 9, 2018
…#1027) * Remove unnecessary StateFunc in https proxy * Support name only certificates * Remove test for the removed validate func
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes extra complexity to make our life easier with MM