Set 'project' attribute when importing 'google_logging_project_sink'

[ewbankkit]

Fixes #1018.

Incorporated the import acceptance test into the main acceptance tests as per current best practice.

Modified acceptance test before setting project attribute:

make testacc TEST=./google TESTARGS='-run=TestAccLoggingProjectSink_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccLoggingProjectSink_basic -timeout 120m
=== RUN   TestAccLoggingProjectSink_basic
--- FAIL: TestAccLoggingProjectSink_basic (5.94s)
	testing.go:513: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
		
		(map[string]string) {
		}
		
		
		(map[string]string) (len=1) {
		 (string) (len=7) "project": (string) (len=11) "root-999999"
		}

and after setting project attribute:

make testacc TEST=./google TESTARGS='-run=TestAccLoggingProjectSink_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccLoggingProjectSink_basic -timeout 120m
=== RUN   TestAccLoggingProjectSink_basic
--- PASS: TestAccLoggingProjectSink_basic (5.56s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	11.741s

[ewbankkit]

Computed: true is now set for the project attribute - I think this breaks backwards compatibility. Shall I write a state migration function?
I think we should be OK with setting Computed: true on the project attribute. I was worried about the case where someone's code doesn't specify the attribute and we now store it in state but this is exactly what Computed is for.

[emilymye]

Can you add a regex check and a default project check here? Similar to KMS key ring

[ewbankkit]

Done. Called parseLoggingSinkId.

[emilymye]

I know it's slightly redundant but I'd prefer not removing this test file and just adding the import tests here.

[ewbankkit]

Done.

[emilymye]

Thanks!

make testacc TEST=./google TESTARGS='-run=TestAccLoggingProjectSink_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccLoggingProjectSink_ -timeout 120m
=== RUN TestAccLoggingProjectSink_importBasic
=== RUN TestAccLoggingProjectSink_basic
=== RUN TestAccLoggingProjectSink_uniqueWriter
=== RUN TestAccLoggingProjectSink_updatePreservesUniqueWriter
--- PASS: TestAccLoggingProjectSink_importBasic (2.95s)
--- PASS: TestAccLoggingProjectSink_basic (3.21s)
--- PASS: TestAccLoggingProjectSink_uniqueWriter (4.03s)
--- PASS: TestAccLoggingProjectSink_updatePreservesUniqueWriter (6.52s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google6.700s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!