Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new compute.instances.update API #6857

Open
danawillow opened this issue Jul 27, 2020 · 3 comments
Open

Use new compute.instances.update API #6857

danawillow opened this issue Jul 27, 2020 · 3 comments

Comments

@danawillow
Copy link
Contributor

https://cloud.google.com/compute/docs/reference/rest/v1/instances/update

@ScottSuarez
Copy link
Collaborator

ScottSuarez commented Sep 17, 2020

Enabling support for this seems quite difficult.
Not all properties can be updated together. Some properties require RESTART and some require REFRESH.

Note: properties that require REFRESH cannot be updated during RESTART.

https://cloud.google.com/compute/docs/instances/update-instance-properties#updatable-properties

edit: RESET -> RESTART

@danawillow
Copy link
Contributor Author

By RESET you mean RESTART, right? My impression from reading that page is that you specify the most disruptive allowed action, and then the API itself decides what to do, which would mean that if you said RESTART was allowed and you passed in a mix of REFRESH and RESTART properties, that it would restart the instance and update all of them.

@ScottSuarez
Copy link
Collaborator

I think your interpretation is the correct one after re-reading the documentation.

@rileykarson rileykarson added size/l and removed size/m labels Dec 6, 2021
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 1, 2022
modular-magician added a commit that referenced this issue Dec 1, 2022
…or bot management (#6857) (#13159)

Signed-off-by: Modular Magician <[email protected]>

Signed-off-by: Modular Magician <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants