-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve charset/collation support for PostgreSQL #260
Comments
#229 removes the MySQL-specific default and adds documentation. |
FWIW, charset/collation are not updatable in PostgreSQL. The semantics are very different in MySQL and PostgreSQL: in MySQL, the database's charset/collation is only used for new tables. In PostgreSQL, charset/collation is database-wide, and updating it requires a dump/restore. So in case of PostgreSQL, charset and collation should be marked with ForceNew. |
More background in #229, specifically #229 (comment). |
More improvements depend on Cloud SQL allowing user-specified charset and collation values (other than UTF8, en_US.UTF8) in the first place. |
I'm closing this for now as further work depends on features / bug fixes in Cloud SQL's PostgreSQL support. Submitted upstream FR. |
<!-- This change is generated by MagicModules. --> /cc @rileykarson
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
From #233: It is also worth mentioning that the collation defaults to a MySQL value which may lead to weird errors with PostgreSQL databases. Support / Documentation for PostgreSQL is needed.
The text was updated successfully, but these errors were encountered: