Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_spanner_database.name validation function needs to allow underscores #2277

Closed
sudoforge opened this issue Oct 17, 2018 · 2 comments
Closed
Labels
bug forward/review In review; remove label to forward service/spanner

Comments

@sudoforge
Copy link

sudoforge commented Oct 17, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

λ terraform version
Terraform v0.11.8
+ provider.google v1.18.0

Affected Resource(s)

  • google_spanner_database

Terraform Configuration Files

resource "google_spanner_database" "foo" {
    instance = "myinstance"
    name = "some_database"
    ...
}

Debug Output

N/A

Panic Output

N/A

Expected Behavior

The database should be created.

Actual Behavior

An error is received upon backend initialization:

Error: google_spanner_database.foo: "name" can only contain lowercase letters, numbers and hyphens

Steps to Reproduce

  1. terraform init

Important Factoids

Underscores are allowed by the upstream API:

λ gcloud spanner database create some_database --project GOOGLE_PROJECT --instance SPANNER_INSTANCE

References

N/A

@sudoforge
Copy link
Author

Closing this in favor GoogleCloudPlatform/magic-modules#583.

@ghost
Copy link

ghost commented Nov 19, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug forward/review In review; remove label to forward service/spanner
Projects
None yet
Development

No branches or pull requests

2 participants