Creating a trigger_template pointing at a different project on google_cloudbuild_trigger creates trigger pointing to host project

[chrisfowles]

Terraform Version

Terraform v0.11.7

Affected Resource(s)

• google_cloudbuild_trigger

Terraform Configuration Files

resource "google_cloudbuild_trigger" "cloudbuild" {
  project = "allegedly-emerging-tiger"

  trigger_template = {
    branch_name = "master"
    project     = "routinely-included-fawn"
    repo_name   = "python-appengine-flask-hello"
  }
}

Debug Output

2018-05-29T15:19:48.652+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: -----------------------------------------------------
2018-05-29T15:19:48.695+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: 2018/05/29 15:19:48 [INFO] build trigger request: {"build":{},"triggerTemplate":{"branchName":"master","projectId":"allegedly-emerging-tiger","repoName":"python-appengine-flask-hello"}}
2018-05-29T15:19:48.696+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: 2018/05/29 15:19:48 [DEBUG] Google API Request Details:
2018-05-29T15:19:48.696+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: ---[ REQUEST ]---------------------------------------
2018-05-29T15:19:48.696+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: POST /v1/projects/allegedly-emerging-tiger/triggers?alt=json HTTP/1.1
2018-05-29T15:19:48.696+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: Host: cloudbuild.googleapis.com
2018-05-29T15:19:48.696+1000 [DEBUG] plugin.terraform-provider-google_v1.13.0_x4: User-Agent: google-api-go-client/0.5 Terraform/0.11.3-dev (+https://www.terraform.io)

Expected Behavior

Trigger should have been created for repo in routinely-included-fawn within container build for allegedly-emerging-tiger project.

Actual Behavior

Trigger was created for repo in llegedly-emerging-tiger.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

References

Bug in #1357

	tmpl := &cloudbuild.RepoSource{}
	if v, ok := d.GetOk("project"); ok {
		tmpl.ProjectId = v.(string)
	} else {
		tmpl.ProjectId = project
	}

should probably be

	tmpl := &cloudbuild.RepoSource{}
	if v, ok := d.GetOk("trigger_template.0.project"); ok {
		tmpl.ProjectId = v.(string)
	} else {
		tmpl.ProjectId = project
	}

[jamielennox]

working with @chrisfowles on this and it seems to solve the problem for us.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!