Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP Netblock Data Source #1416

Closed
jacobwoffenden opened this issue May 2, 2018 · 6 comments
Closed

GCP Netblock Data Source #1416

jacobwoffenden opened this issue May 2, 2018 · 6 comments
Labels
enhancement new-resource

Comments

@jacobwoffenden
Copy link

Hi,

It would be good if there was an IP range data source in the Google provider like Cloudflare's
@jacobwoffenden jacobwoffenden changed the title GCP Netblock Datasource GCP Netblock Data Source May 2, 2018
@rosbo
Copy link
Contributor

rosbo commented May 2, 2018

Would this data source meet your needs?
https://www.terraform.io/docs/providers/google/d/datasource_compute_lb_ip_ranges.html

@jacobwoffenden
Copy link
Author

According to the link on that page, this only covers

  • 209.85.152.0/22
  • 209.85.204.0/22
  • 35.191.0.0/16

I'm ultimately trying to lockdown SSH access to an instance from Google Cloud Shell, and according to what I've read on the internet, it can use any IP from _cloud-netblocks.googleusercontent.com.

I understand the security implications of opening up SSH to the GCP netblock, but I still think it would be a good feature to have instead of having to manually gather the source IPs.

For now, I will look at using a workaround of dynamically updating firewall rules via gcloud cli

@morgante
Copy link

@rosbo Do you think this is a good idea? I know it would be useful for some other customers, even in cases where they're configuring other clouds via Terraform as well (in a multi-cloud environment).

@rosbo
Copy link
Contributor

rosbo commented May 29, 2018

I think this is a good idea. I won't have time to work on this the next few weeks but we always welcome contributions :) Let me know if you need help.

@morgante
Copy link

Thanks, I'll have someone implement it.

ortaman pushed a commit to ortaman/terraform-provider-google that referenced this issue Jun 1, 2018
Added GCP Netblock Data Source (hashicorp#1416)
53ebfc9
@ortaman ortaman mentioned this issue Jun 1, 2018
Merged
ortaman pushed a commit to ortaman/terraform-provider-google that referenced this issue Jun 2, 2018
Added docs for google_netblock_ip_ranges (hashicorp#1416)
79d2636
ortaman pushed a commit to ortaman/terraform-provider-google that referenced this issue Jun 4, 2018
Code review changes (hashicorp#1416)
409877b
rosbo pushed a commit that referenced this issue Jun 4, 2018
@ortaman @rosbo
Added GCP Netblock Data Source (#1416) (#1580)
6864f1f 
* Added GCP Netblock Data Source (#1416)

* Added docs for google_netblock_ip_ranges (#1416)

* Code review changes (#1416)
olvesh pushed a commit to olvesh/terraform-provider-google that referenced this issue Jun 8, 2018
Merge branch 'master' of https://github.com/olvesh/terraform-provider…
a223776 
…-google

* 'master' of https://github.com/olvesh/terraform-provider-google: (24 commits)
  Cleanup after v1.14.0 release
  v1.14.0
  Update CHANGELOG.md
  Add new google_compute_regions (hashicorp#1603)
  Update CHANGELOG.md
  Fix forwarding rule data source test (hashicorp#1606)
  Update CHANGELOG.md
  Fix redis authorized network and tests. The Redis API currently only accepts partial links. The tests weren't failing because they weren't actually using the network (oops). There were a few other test issues that I fixed while I was there. Fixes hashicorp#1571. (hashicorp#1599)
  update auth docs (hashicorp#1587)
  Fix network_tier tests.
  Add documentation for network tier (hashicorp#1593)
  Warn about ip_version with ip_address in global forwarding rule (hashicorp#616)
  Update CHANGELOG.md
  add support for network tiers (hashicorp#1530)
  Update CHANGELOG.md
  Allow using in repo configuration for cloudbuild trigger (hashicorp#1557)
  Update CHANGELOG.md
  add update support for redis (hashicorp#1590)
  Update CHANGELOG.md
  Added GCP Netblock Data Source (hashicorp#1416) (hashicorp#1580)
  ...
chrisst pushed a commit to chrisst/terraform-provider-google that referenced this issue Nov 9, 2018
@ortaman @rosbo
Added GCP Netblock Data Source (hashicorp#1416) (hashicorp#1580)
ed0a84f 
* Added GCP Netblock Data Source (hashicorp#1416)

* Added docs for google_netblock_ip_ranges (hashicorp#1416)

* Code review changes (hashicorp#1416)
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement new-resource
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paddycarver @rosbo @morgante @jacobwoffenden