Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for folders #132

Closed
ubschmidt2 opened this issue Jun 16, 2017 · 5 comments
Closed

Add support for folders #132

ubschmidt2 opened this issue Jun 16, 2017 · 5 comments

Comments

@ubschmidt2
Copy link
Contributor

Terraform Version

Terraform v0.10.0-dev (9706042ddd51b85a46e23356536a1d812efa5a38+CHANGES)

Affected Resource(s)

  • google_project

References

@danawillow
Copy link
Contributor

This is blocked on #93, but is absolutely on our radar.

@rileykarson
Copy link
Collaborator

Looking at https://cloud.google.com/resource-manager/docs/creating-managing-folders, it looks like this has entered GA.

@ubschmidt2
Copy link
Contributor Author

Identified use cases:

  • affecting the existing resource type "google_project":
    • create a new GCP project in a given existing GCP folder.
      (Implementation note: I'd suggest to add a "folder_id" attribute to "google_project". This should only require a minor change to the call to v1/projects/create. If "folder_id" is set, then parent ResourceId.type="folder".)
    • move a TF-managed GCP project between folders and between org node and folder.
      (Implementation note: This should be just a matter of updating the project with the appropriate parent ResourceId.)
  • for configuring GCP folders:
    • create a new GCP folder (+destroy)
      (Implementation note: uses the resource-manager v2/folders API. New TF resource type "google_folder".)
    • move a TF-managed GCP folder into a given existing GCP folder or to the org node.
      (Implementation note: see the v2/folders/move API.)
    • configure the IAM policy of a GCP folder.
      (Implementation note: This looks very similar to what already exists for "google_project". However, since IAM policies can be set on many different resource types, it might make sense to revisit the current approach, maybe it can be generalized a bit so that it works for other resource types, too.)
    • configure constraints on a GCP folder.
      (Implementation note: Constraints can be set on the org node, folder(s), and the project, thus need a solution that works (or could be extended to work) for all levels.)

@rosbo
Copy link
Contributor

rosbo commented Sep 12, 2017

I created 4 new issues to track the different use cases we identified to make it easier to track progress.

This task will be kept open until all children issues are resolved.

#411 is being tackled by @ubschmidt2 & @srivasta
#412 is being tackled by @rosbo
I (@rosbo) will probably take over #413 once I am done with #412.

#414 is up for grab. I might take it if I have the bandwidth once I am done with #412 and #413

cc/ @danawillow

@rosbo rosbo closed this as completed Nov 27, 2017
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this issue May 21, 2019
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants