Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only assign terraform reviewer when a pr is in a non-draft state #12570

Open
ScottSuarez opened this issue Sep 15, 2022 · 3 comments
Open

Only assign terraform reviewer when a pr is in a non-draft state #12570

ScottSuarez opened this issue Sep 15, 2022 · 3 comments

Comments

@ScottSuarez
Copy link
Collaborator

ScottSuarez commented Sep 15, 2022

Affected Resource(s)

  • google_*

Unsure if we can hook into this.

However it would be nice to not get assigned to changes until they are ready for review, maybe with an automated comment saying we won't assign anyone until the change is ready.

@melinath
Copy link
Collaborator

I think this is already the behavior - but it only works if the PR is created in draft mode (rather than being converted after the fact). I wonder if there's a way to force draft mode?

@ScottSuarez
Copy link
Collaborator Author

oh interesting ! I didn't realize. Perhaps the CLs that were assigned to me were converted to draft by the contributor.

I'll have to take a look.

@rileykarson
Copy link
Collaborator

rileykarson commented Sep 19, 2022

There's a wider question about overall workflow w/ draft PRs, a user that needs the most help is often the one that's clicked "Draft" rather than opening a traditional PR.

OTOH there's things like changelog checks that could be deferred to the full PR.

@rileykarson rileykarson added this to the Goals milestone Sep 19, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Dec 20, 2024
[upstream:1a28a91cf77e481d012718eec9bdf7524c663e4f]

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Dec 20, 2024
[upstream:1a28a91cf77e481d012718eec9bdf7524c663e4f]

Signed-off-by: Modular Magician <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants