Sort IAM policy bindings' members to get simpler diffs as it's what t…

…he API does
hashicorp · Jun 19, 2019 · fc25f8a · fc25f8a
1 parent c54b2cd
commit fc25f8a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/google/data_source_google_iam_policy.go b/google/data_source_google_iam_policy.go
@@ -98,9 +98,14 @@ func dataSourceGoogleIamPolicyRead(d *schema.ResourceData, meta interface{}) err
 	// Convert each config binding into a cloudresourcemanager.Binding
 	for i, v := range bset.List() {
 		binding := v.(map[string]interface{})
+		members := convertStringSet(binding["members"].(*schema.Set))
+
+		// Sort members to get simpler diffs as it's what the API does
+		sort.Strings(members)
+
 		policy.Bindings[i] = &cloudresourcemanager.Binding{
 			Role:    binding["role"].(string),
-			Members: convertStringSet(binding["members"].(*schema.Set)),
+			Members: members,
 		}
 	}