Add PTR records to compute instance.

hashicorp · Apr 17, 2018 · a8fc466 · a8fc466
1 parent 8a2918c
commit a8fc466
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 0 deletions.
diff --git a/google/resource_compute_instance.go b/google/resource_compute_instance.go
@@ -365,6 +365,11 @@ func resourceComputeInstance() *schema.Resource {
 										Type:     schema.TypeString,
 										Computed: true,
 									},
+
+									"public_ptr_domain_name": &schema.Schema{
+										Type:     schema.TypeString,
+										Optional: true,
+									},
 								},
 							},
 						},
@@ -1120,6 +1125,10 @@ func resourceComputeInstanceUpdate(d *schema.ResourceData, meta interface{}) err
 					Type:  "ONE_TO_ONE_NAT",
 					NatIP: d.Get(acPrefix + ".nat_ip").(string),
 				}
+				if ptr, ok := d.GetOk(acPrefix + ".public_ptr_domain_name"); ok {
+					ac.SetPublicPtr = true
+					ac.PublicPtrDomainName = ptr.(string)
+				}
 				op, err := config.clientCompute.Instances.AddAccessConfig(
 					project, zone, d.Id(), networkName, ac).Do()
 				if err != nil {

diff --git a/google/resource_compute_instance_test.go b/google/resource_compute_instance_test.go
@@ -186,6 +186,30 @@ func TestAccComputeInstance_IP(t *testing.T) {
 	})
 }
 
+func TestAccComputeInstance_PTRRecord(t *testing.T) {
+	t.Parallel()
+
+	var instance compute.Instance
+	var ptrName = fmt.Sprintf("instance-test-%s", acctest.RandString(10))
+	var instanceName = fmt.Sprintf("instance-test-%s", acctest.RandString(10))
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckComputeInstanceDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: testAccComputeInstance_PTRRecord(ptrName, instanceName),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckComputeInstanceExists(
+						"google_compute_instance.foobar", &instance),
+					testAccCheckComputeInstanceAccessConfigHasPTR(&instance),
+				),
+			},
+		},
+	})
+}
+
 func TestAccComputeInstance_GenerateIP(t *testing.T) {
 	var instance compute.Instance
 	var instanceName = fmt.Sprintf("instance-test-%s", acctest.RandString(10))
@@ -1148,6 +1172,20 @@ func testAccCheckComputeInstanceAccessConfigHasIP(instance *compute.Instance) re
 	}
 }
 
+func testAccCheckComputeInstanceAccessConfigHasPTR(instance *compute.Instance) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		for _, i := range instance.NetworkInterfaces {
+			for _, c := range i.AccessConfigs {
+				if c.PublicPtrDomainName == "" {
+					return fmt.Errorf("no PTR Record")
+				}
+			}
+		}
+
+		return nil
+	}
+}
+
 func testAccCheckComputeInstanceDisk(instance *compute.Instance, source string, delete bool, boot bool) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		if instance.Disks == nil {
@@ -1750,6 +1788,34 @@ resource "google_compute_instance" "foobar" {
 `, ip, instance)
 }
 
+func testAccComputeInstance_PTRRecord(record, instance string) string {
+	return fmt.Sprintf(`
+resource "google_compute_instance" "foobar" {
+	name         = "%s"
+	machine_type = "n1-standard-1"
+	zone         = "us-central1-a"
+	tags         = ["foo", "bar"]
+
+	boot_disk {
+		initialize_params{
+			image = "debian-8-jessie-v20160803"
+		}
+	}
+
+	network_interface {
+		network = "default"
+		access_config {
+			public_ptr_domain_name = "test-record.%s.hashicorptest.com."
+		}
+	}
+
+	metadata {
+		foo = "bar"
+	}
+}
+`, instance, record)
+}
+
 func testAccComputeInstance_generateIp(instance string) string {
 	return fmt.Sprintf(`
 resource "google_compute_instance" "foobar" {