Add import support for google_compute_backend_bucket (#736)

* Add import support for google_compute_backend_bucket * Improve docs for consistency
hashicorp · Nov 13, 2017 · a6378fc · a6378fc
1 parent c8d2131
commit a6378fc
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 1 deletion.
diff --git a/google/import_compute_backend_bucket_test.go b/google/import_compute_backend_bucket_test.go
@@ -0,0 +1,31 @@
+package google
+
+import (
+	"fmt"
+	"github.com/hashicorp/terraform/helper/acctest"
+	"github.com/hashicorp/terraform/helper/resource"
+	"testing"
+)
+
+func TestAccComputeBackendBucket_import(t *testing.T) {
+	t.Parallel()
+
+	backendName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
+	storageName := fmt.Sprintf("tf-test-%s", acctest.RandString(10))
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:     func() { testAccPreCheck(t) },
+		Providers:    testAccProviders,
+		CheckDestroy: testAccCheckComputeBackendBucketDestroy,
+		Steps: []resource.TestStep{
+			resource.TestStep{
+				Config: testAccComputeBackendBucket_basic(backendName, storageName),
+			},
+			resource.TestStep{
+				ResourceName:      "google_compute_backend_bucket.foobar",
+				ImportState:       true,
+				ImportStateVerify: true,
+			},
+		},
+	})
+}
diff --git a/google/resource_compute_backend_bucket.go b/google/resource_compute_backend_bucket.go
@@ -15,6 +15,10 @@ func resourceComputeBackendBucket() *schema.Resource {
 		Update: resourceComputeBackendBucketUpdate,
 		Delete: resourceComputeBackendBucketDelete,
 
+		Importer: &schema.ResourceImporter{
+			State: schema.ImportStatePassthrough,
+		},
+
 		Schema: map[string]*schema.Schema{
 			"name": &schema.Schema{
 				Type:         schema.TypeString,
@@ -111,6 +115,7 @@ func resourceComputeBackendBucketRead(d *schema.ResourceData, meta interface{})
 		return handleNotFoundError(err, d, fmt.Sprintf("Backend Bucket %q", d.Get("name").(string)))
 	}
 
+	d.Set("name", bucket.Name)
 	d.Set("bucket_name", bucket.BucketName)
 	d.Set("description", bucket.Description)
 	d.Set("enable_cdn", bucket.EnableCdn)

diff --git a/website/docs/r/compute_backend_bucket.html.markdown b/website/docs/r/compute_backend_bucket.html.markdown
@@ -17,7 +17,7 @@ and
 ## Example Usage
 
 ```hcl
-resource "google_compute_backend_bucket" "foobar" {
+resource "google_compute_backend_bucket" "image_backend" {
   name        = "image-backend-bucket"
   description = "Contains beautiful images"
   bucket_name = "${google_storage_bucket.image_bucket.name}"
@@ -53,3 +53,11 @@ The following arguments are supported:
 In addition to the arguments listed above, the following computed attributes are exported:
 
 * `self_link` - The URI of the created resource.
+
+## Import
+
+Backend buckets can be imported using the `name`, e.g.
+
+```
+$ terraform import google_compute_backend_bucket.image_backend image-backend-bucket
+```