Skip to content

Commit

Permalink
V1 (#4253) (#7933)
Browse files Browse the repository at this point in the history
* Update to v1 API

* Remove default option

* Restore v1beta1

* Update v1 order

* update iam tests to work correctly

* removed a < that corrupted compiliation

Co-authored-by: Scott Suarez <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Scott Suarez <[email protected]>
  • Loading branch information
modular-magician and ScottSuarez authored Dec 4, 2020
1 parent c0b8270 commit 3fd0300
Show file tree
Hide file tree
Showing 18 changed files with 3,230 additions and 15 deletions.
4 changes: 4 additions & 0 deletions .changelog/4253.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:enhancement
notebooks: promoted `google_notebooks_instance` to GA
notebooks: promoted `google_notebooks_environment` to GA
```
3 changes: 3 additions & 0 deletions google/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ type Config struct {
MLEngineBasePath string
MonitoringBasePath string
NetworkManagementBasePath string
NotebooksBasePath string
OSConfigBasePath string
OSLoginBasePath string
PubsubBasePath string
Expand Down Expand Up @@ -193,6 +194,7 @@ var LoggingDefaultBasePath = "https://logging.googleapis.com/v2/"
var MLEngineDefaultBasePath = "https://ml.googleapis.com/v1/"
var MonitoringDefaultBasePath = "https://monitoring.googleapis.com/"
var NetworkManagementDefaultBasePath = "https://networkmanagement.googleapis.com/v1/"
var NotebooksDefaultBasePath = "https://notebooks.googleapis.com/v1/"
var OSConfigDefaultBasePath = "https://osconfig.googleapis.com/v1/"
var OSLoginDefaultBasePath = "https://oslogin.googleapis.com/v1/"
var PubsubDefaultBasePath = "https://pubsub.googleapis.com/v1/"
Expand Down Expand Up @@ -977,6 +979,7 @@ func ConfigureBasePaths(c *Config) {
c.MLEngineBasePath = MLEngineDefaultBasePath
c.MonitoringBasePath = MonitoringDefaultBasePath
c.NetworkManagementBasePath = NetworkManagementDefaultBasePath
c.NotebooksBasePath = NotebooksDefaultBasePath
c.OSConfigBasePath = OSConfigDefaultBasePath
c.OSLoginBasePath = OSLoginDefaultBasePath
c.PubsubBasePath = PubsubDefaultBasePath
Expand Down
222 changes: 222 additions & 0 deletions google/iam_notebooks_instance.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,222 @@
// ----------------------------------------------------------------------------
//
// *** AUTO GENERATED CODE *** AUTO GENERATED CODE ***
//
// ----------------------------------------------------------------------------
//
// This file is automatically generated by Magic Modules and manual
// changes will be clobbered when the file is regenerated.
//
// Please read more about how to change this file in
// .github/CONTRIBUTING.md.
//
// ----------------------------------------------------------------------------
package google

import (
"fmt"

"github.com/hashicorp/errwrap"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"google.golang.org/api/cloudresourcemanager/v1"
)

var NotebooksInstanceIamSchema = map[string]*schema.Schema{
"project": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
},
"location": {
Type: schema.TypeString,
Computed: true,
Optional: true,
ForceNew: true,
},
"instance_name": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
DiffSuppressFunc: compareSelfLinkOrResourceName,
},
}

type NotebooksInstanceIamUpdater struct {
project string
location string
instanceName string
d *schema.ResourceData
Config *Config
}

func NotebooksInstanceIamUpdaterProducer(d *schema.ResourceData, config *Config) (ResourceIamUpdater, error) {
values := make(map[string]string)

project, _ := getProject(d, config)
if project != "" {
if err := d.Set("project", project); err != nil {
return nil, fmt.Errorf("Error setting project: %s", err)
}
}
values["project"] = project
location, _ := getLocation(d, config)
if location != "" {
if err := d.Set("location", location); err != nil {
return nil, fmt.Errorf("Error setting location: %s", err)
}
}
values["location"] = location
if v, ok := d.GetOk("instance_name"); ok {
values["instance_name"] = v.(string)
}

// We may have gotten either a long or short name, so attempt to parse long name if possible
m, err := getImportIdQualifiers([]string{"projects/(?P<project>[^/]+)/locations/(?P<location>[^/]+)/instances/(?P<instance_name>[^/]+)", "(?P<project>[^/]+)/(?P<location>[^/]+)/(?P<instance_name>[^/]+)", "(?P<location>[^/]+)/(?P<instance_name>[^/]+)", "(?P<instance_name>[^/]+)"}, d, config, d.Get("instance_name").(string))
if err != nil {
return nil, err
}

for k, v := range m {
values[k] = v
}

u := &NotebooksInstanceIamUpdater{
project: values["project"],
location: values["location"],
instanceName: values["instance_name"],
d: d,
Config: config,
}

if err := d.Set("project", u.project); err != nil {
return nil, fmt.Errorf("Error setting project: %s", err)
}
if err := d.Set("location", u.location); err != nil {
return nil, fmt.Errorf("Error setting location: %s", err)
}
if err := d.Set("instance_name", u.GetResourceId()); err != nil {
return nil, fmt.Errorf("Error setting instance_name: %s", err)
}

return u, nil
}

func NotebooksInstanceIdParseFunc(d *schema.ResourceData, config *Config) error {
values := make(map[string]string)

project, _ := getProject(d, config)
if project != "" {
values["project"] = project
}

location, _ := getLocation(d, config)
if location != "" {
values["location"] = location
}

m, err := getImportIdQualifiers([]string{"projects/(?P<project>[^/]+)/locations/(?P<location>[^/]+)/instances/(?P<instance_name>[^/]+)", "(?P<project>[^/]+)/(?P<location>[^/]+)/(?P<instance_name>[^/]+)", "(?P<location>[^/]+)/(?P<instance_name>[^/]+)", "(?P<instance_name>[^/]+)"}, d, config, d.Id())
if err != nil {
return err
}

for k, v := range m {
values[k] = v
}

u := &NotebooksInstanceIamUpdater{
project: values["project"],
location: values["location"],
instanceName: values["instance_name"],
d: d,
Config: config,
}
if err := d.Set("instance_name", u.GetResourceId()); err != nil {
return fmt.Errorf("Error setting instance_name: %s", err)
}
d.SetId(u.GetResourceId())
return nil
}

func (u *NotebooksInstanceIamUpdater) GetResourceIamPolicy() (*cloudresourcemanager.Policy, error) {
url, err := u.qualifyInstanceUrl("getIamPolicy")
if err != nil {
return nil, err
}

project, err := getProject(u.d, u.Config)
if err != nil {
return nil, err
}
var obj map[string]interface{}

userAgent, err := generateUserAgentString(u.d, u.Config.userAgent)
if err != nil {
return nil, err
}

policy, err := sendRequest(u.Config, "GET", project, url, userAgent, obj)
if err != nil {
return nil, errwrap.Wrapf(fmt.Sprintf("Error retrieving IAM policy for %s: {{err}}", u.DescribeResource()), err)
}

out := &cloudresourcemanager.Policy{}
err = Convert(policy, out)
if err != nil {
return nil, errwrap.Wrapf("Cannot convert a policy to a resource manager policy: {{err}}", err)
}

return out, nil
}

func (u *NotebooksInstanceIamUpdater) SetResourceIamPolicy(policy *cloudresourcemanager.Policy) error {
json, err := ConvertToMap(policy)
if err != nil {
return err
}

obj := make(map[string]interface{})
obj["policy"] = json

url, err := u.qualifyInstanceUrl("setIamPolicy")
if err != nil {
return err
}
project, err := getProject(u.d, u.Config)
if err != nil {
return err
}

userAgent, err := generateUserAgentString(u.d, u.Config.userAgent)
if err != nil {
return err
}

_, err = sendRequestWithTimeout(u.Config, "POST", project, url, userAgent, obj, u.d.Timeout(schema.TimeoutCreate))
if err != nil {
return errwrap.Wrapf(fmt.Sprintf("Error setting IAM policy for %s: {{err}}", u.DescribeResource()), err)
}

return nil
}

func (u *NotebooksInstanceIamUpdater) qualifyInstanceUrl(methodIdentifier string) (string, error) {
urlTemplate := fmt.Sprintf("{{NotebooksBasePath}}%s:%s", fmt.Sprintf("projects/%s/locations/%s/instances/%s", u.project, u.location, u.instanceName), methodIdentifier)
url, err := replaceVars(u.d, u.Config, urlTemplate)
if err != nil {
return "", err
}
return url, nil
}

func (u *NotebooksInstanceIamUpdater) GetResourceId() string {
return fmt.Sprintf("projects/%s/locations/%s/instances/%s", u.project, u.location, u.instanceName)
}

func (u *NotebooksInstanceIamUpdater) GetMutexKey() string {
return fmt.Sprintf("iam-notebooks-instance-%s", u.GetResourceId())
}

func (u *NotebooksInstanceIamUpdater) DescribeResource() string {
return fmt.Sprintf("notebooks instance %q", u.GetResourceId())
}
Loading

0 comments on commit 3fd0300

Please sign in to comment.