test improvement

hashicorp · Nov 2, 2017 · 1fb2e80 · 1fb2e80
1 parent f0e705f
commit 1fb2e80
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/google/resource_container_cluster.go b/google/resource_container_cluster.go
@@ -933,6 +933,14 @@ func flattenClusterAddonsConfig(c *container.AddonsConfig) []map[string]interfac
 			},
 		}
 	}
+
+	if c.NetworkPolicyConfig != nil {
+		result["network_policy"] = []map[string]interface{}{
+			{
+				"disabled": c.NetworkPolicyConfig.Disabled,
+			},
+		}
+	}
 	return []map[string]interface{}{result}
 }
 

diff --git a/google/resource_container_cluster_test.go b/google/resource_container_cluster_test.go
@@ -72,6 +72,7 @@ func TestAccContainerCluster_withAddons(t *testing.T) {
 						"google_container_cluster.primary"),
 					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.http_load_balancing.0.disabled", "true"),
 					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.kubernetes_dashboard.0.disabled", "true"),
+					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.network_policy.0.disabled", "false"),
 				),
 			},
 			{
@@ -82,6 +83,7 @@ func TestAccContainerCluster_withAddons(t *testing.T) {
 					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.horizontal_pod_autoscaling.0.disabled", "true"),
 					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.http_load_balancing.0.disabled", "false"),
 					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.kubernetes_dashboard.0.disabled", "true"),
+					resource.TestCheckResourceAttr("google_container_cluster.primary", "addons_config.0.kubernetes_dashboard.0.disabled", "true"),
 				),
 			},
 		},
@@ -920,7 +922,7 @@ resource "google_container_cluster" "primary" {
 	addons_config {
 		http_load_balancing { disabled = true }
 		kubernetes_dashboard { disabled = true }
-		network_policy { disabled = true }
+		network_policy { disabled = false }
 	}
 }`, clusterName)
 }
@@ -936,7 +938,7 @@ resource "google_container_cluster" "primary" {
 		http_load_balancing { disabled = false }
 		kubernetes_dashboard { disabled = true }
 		horizontal_pod_autoscaling { disabled = true }
-		network_policy { disabled = false }
+		network_policy { disabled = true }
 	}
 }`, clusterName)
 }