Skip to content

Commit

Permalink
Remove update_strategy from rigm. (#2594)
Browse files Browse the repository at this point in the history
<!-- This change is generated by MagicModules. -->
/cc @rileykarson
  • Loading branch information
modular-magician authored and paddycarver committed Dec 14, 2018
1 parent 494ba48 commit 112cd74
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
9 changes: 4 additions & 5 deletions google/resource_compute_region_instance_group_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,10 @@ func resourceComputeRegionInstanceGroupManager() *schema.Resource {
},

"update_strategy": &schema.Schema{
Type: schema.TypeString,
Deprecated: "This field is deprecated as it has no functionality anymore. It will be removed in 3.0.0.",
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{"NONE", "ROLLING_UPDATE"}, false),
Type: schema.TypeString,
Deprecated: "This field is removed.",
Optional: true,
Computed: true,
},

"target_pools": &schema.Schema{
Expand Down
8 changes: 3 additions & 5 deletions google/resource_compute_region_instance_group_manager_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,9 @@ func TestAccRegionInstanceGroupManager_updateStrategy(t *testing.T) {
Config: testAccRegionInstanceGroupManager_updateStrategy(igm),
},
{
ResourceName: "google_compute_region_instance_group_manager.igm-update-strategy",
ImportState: true,
ImportStateVerify: true,
ImportStateVerifyIgnore: []string{"update_strategy"},
ResourceName: "google_compute_region_instance_group_manager.igm-update-strategy",
ImportState: true,
ImportStateVerify: true,
},
},
})
Expand Down Expand Up @@ -648,7 +647,6 @@ resource "google_compute_region_instance_group_manager" "igm-update-strategy" {
base_instance_name = "rigm-update-strategy"
region = "us-central1"
target_size = 2
update_strategy = "NONE"
named_port {
name = "customhttp"
port = 8080
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ The following arguments are supported:
* `project` - (Optional) The ID of the project in which the resource belongs. If it
is not provided, the provider project is used.

* `update_strategy` - (Optional, Default `"NONE"`) This field is deprecated as it has no functionality anymore.
It previously turned update behaviour on and off. This field is only present in the `google` provider.

* `target_size` - (Optional) The target number of running instances for this managed
instance group. This value should always be explicitly set unless this resource is attached to
an autoscaler, in which case it should never be set. Defaults to `0`.
Expand Down

0 comments on commit 112cd74

Please sign in to comment.