Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DNS resources to fix SSL test #4819

Conversation

modular-magician
Copy link
Collaborator

simple fix for the failing TestAccComputeManagedSslCertificate_managedSslCertificateBasicExample test. DNS records are not needed to create an SSL cert or to associate it with a proxy/URL map.

Yes, technically the cert will never actually be live due to the failed DNS check. But we're deleting the cert object anyways way before any validation can be completely successfully.

fixes {hashicorp/terraform-provider-google#12528 }

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#6726

Co-authored-by: Ghaleb Al-habian <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 256103d into hashicorp:main Oct 24, 2022
@modular-magician modular-magician deleted the downstream-pr-6515eb51e7e80a620ceea447da18a93739822ad6 branch November 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant