Firestore: Mark identifier fields as immutable. (#11174) (#7791)

[upstream:0ed911c6f2744cb4cfeba8c7a5768ea46befa8ca] Signed-off-by: Modular Magician <[email protected]>
hashicorp · Jul 23, 2024 · eb6fb2a · eb6fb2a
1 parent dc36e60
commit eb6fb2a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/.changelog/11174.txt b/.changelog/11174.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+firestore: fixes bug where fields database, collection, document_id, and field on resources could not be updated. 
+```
diff --git a/google-beta/services/firestore/resource_firestore_document.go b/google-beta/services/firestore/resource_firestore_document.go
@@ -60,11 +60,13 @@ func ResourceFirestoreDocument() *schema.Resource {
 			"collection": {
 				Type:        schema.TypeString,
 				Required:    true,
+				ForceNew:    true,
 				Description: `The collection ID, relative to database. For example: chatrooms or chatrooms/my-document/private-messages.`,
 			},
 			"document_id": {
 				Type:        schema.TypeString,
 				Required:    true,
+				ForceNew:    true,
 				Description: `The client-assigned document ID to use for this document during creation.`,
 			},
 			"fields": {
@@ -77,6 +79,7 @@ func ResourceFirestoreDocument() *schema.Resource {
 			"database": {
 				Type:        schema.TypeString,
 				Optional:    true,
+				ForceNew:    true,
 				Description: `The Firestore database id. Defaults to '"(default)"'.`,
 				Default:     "(default)",
 			},

diff --git a/google-beta/services/firestore/resource_firestore_field.go b/google-beta/services/firestore/resource_firestore_field.go
@@ -59,16 +59,19 @@ func ResourceFirestoreField() *schema.Resource {
 			"collection": {
 				Type:        schema.TypeString,
 				Required:    true,
+				ForceNew:    true,
 				Description: `The id of the collection group to configure.`,
 			},
 			"field": {
 				Type:        schema.TypeString,
 				Required:    true,
+				ForceNew:    true,
 				Description: `The id of the field to configure.`,
 			},
 			"database": {
 				Type:        schema.TypeString,
 				Optional:    true,
+				ForceNew:    true,
 				Description: `The Firestore database id. Defaults to '"(default)"'.`,
 				Default:     "(default)",
 			},