mark nil errors as nil instead of non-retryable (#4124) (#2618)

Signed-off-by: Modular Magician <[email protected]>
hashicorp · Oct 19, 2020 · e1f1537 · e1f1537
1 parent 2fd3bea
commit e1f1537
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.changelog/4124.txt b/.changelog/4124.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+all: fixed misleading "empty non-retryable error" message that was appearing in debug logs
+```
diff --git a/google-beta/retry_transport.go b/google-beta/retry_transport.go
@@ -201,6 +201,9 @@ func (t *retryTransport) checkForRetryableError(resp *http.Response, respErr err
 		errToCheck = googleapi.CheckResponse(&respToCheck)
 	}
 
+	if errToCheck == nil {
+		return nil
+	}
 	if isRetryableError(errToCheck, t.retryPredicates...) {
 		return resource.RetryableError(errToCheck)
 	}