-
Notifications
You must be signed in to change notification settings - Fork 263
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix TestAccSqlUser_postgresIAM by using a real IAM user (#10731) (#7402)
[upstream:45be142d046f4aa453fd4d02c092508860718a0c] Signed-off-by: Modular Magician <[email protected]>
- Loading branch information
1 parent
ac878b3
commit c887b98
Showing
1 changed file
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -138,10 +138,10 @@ func TestAccSqlUser_postgres(t *testing.T) { | |
} | ||
|
||
func TestAccSqlUser_postgresIAM(t *testing.T) { | ||
t.Skipf("Skipping test %s due to https://github.com/hashicorp/terraform-provider-google/issues/16704", t.Name()) | ||
t.Parallel() | ||
|
||
instance := fmt.Sprintf("tf-test-%d", acctest.RandInt(t)) | ||
const iamUser = "[email protected]" | ||
acctest.VcrTest(t, resource.TestCase{ | ||
PreCheck: func() { acctest.AccTestPreCheck(t) }, | ||
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t), | ||
|
@@ -151,14 +151,14 @@ func TestAccSqlUser_postgresIAM(t *testing.T) { | |
CheckDestroy: testAccSqlUserDestroyProducer(t), | ||
Steps: []resource.TestStep{ | ||
{ | ||
Config: testGoogleSqlUser_postgresIAM(instance), | ||
Config: testGoogleSqlUser_postgresIAM(instance, iamUser), | ||
Check: resource.ComposeTestCheckFunc( | ||
testAccCheckGoogleSqlUserExists(t, "google_sql_user.user"), | ||
), | ||
}, | ||
{ | ||
ResourceName: "google_sql_user.user", | ||
ImportStateId: fmt.Sprintf("%s/%s/admin", envvar.GetTestProjectFromEnv(), instance), | ||
ImportStateId: fmt.Sprintf("%s/%s/%s", envvar.GetTestProjectFromEnv(), instance, iamUser), | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
ImportStateVerifyIgnore: []string{"password"}, | ||
|
@@ -406,7 +406,7 @@ resource "google_sql_user" "user" { | |
`, instance, password) | ||
} | ||
|
||
func testGoogleSqlUser_postgresIAM(instance string) string { | ||
func testGoogleSqlUser_postgresIAM(instance, iamUser string) string { | ||
return fmt.Sprintf(` | ||
resource "google_sql_database_instance" "instance" { | ||
name = "%s" | ||
|
@@ -424,19 +424,19 @@ resource "google_sql_database_instance" "instance" { | |
} | ||
# TODO: Remove with resolution of https://github.com/hashicorp/terraform-provider-google/issues/14233 | ||
resource "time_sleep" "wait_30_seconds" { | ||
resource "time_sleep" "wait_60_seconds" { | ||
depends_on = [google_sql_database_instance.instance] | ||
create_duration = "30s" | ||
create_duration = "60s" | ||
} | ||
resource "google_sql_user" "user" { | ||
depends_on = [time_sleep.wait_30_seconds] | ||
name = "admin" | ||
depends_on = [time_sleep.wait_60_seconds] | ||
name = "%s" | ||
instance = google_sql_database_instance.instance.name | ||
type = "CLOUD_IAM_USER" | ||
} | ||
`, instance) | ||
`, instance, iamUser) | ||
} | ||
|
||
func testGoogleSqlUser_postgresAbandon(instance, name string) string { | ||
|