Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add support for running tests on Windows #90

Merged
merged 3 commits into from
Sep 28, 2018
Merged

Add support for running tests on Windows #90

merged 3 commits into from
Sep 28, 2018

Conversation

AndreLouisCaron
Copy link
Contributor

Replaces #58 and #59.

@AndreLouisCaron
Add batch file clones of the unix shell scripts
3312ac2
@AndreLouisCaron
Update go-winio
f176d04 
The test suite was flaky on Windows due to some internal bug in
connecting to the named pipe endpoint in Docker for Windows' Docker
daemon.  The latest version of `go-winio` includes a fix that makes the
connection much more stable.
@ghost ghost added size/XL labels Sep 25, 2018
This was referenced Sep 25, 2018
Closed
Closed
@mavogel mavogel added this to the v1.0.3 milestone Sep 25, 2018
@AndreLouisCaron
Copy link
Contributor Author

Hmmm, it looks like I hit appveyor/ci#1717. See Run Linux and Windows containers on AppVeyor with Docker CE.

Linux containers are currently available on our new flavor of build VMs - Premium workers.

Seems like this is only available as a paid option...

@mavogel
Copy link
Contributor

mavogel commented Sep 25, 2018

What a pity. But I will merge your PR. Let's see if they enable it for the free version in the future. I will also ask if Hashicorp has an internal tool to run tests on windows. Nevertheless, travis builds 2 binaries for windows but I know this does not verify the functionality. Until now this can only be verified with windows machine (which I don't have access to atm) or a Windows VM..
Thx for the update @AndreLouisCaron

@AndreLouisCaron
Copy link
Contributor Author

In the meantime, would you like me to remove the appveyor.yml since I can't even tell if it works or not?

@mavogel
Copy link
Contributor

mavogel commented Sep 26, 2018

Yes that makes sense because we have to test the .bat scripts manually anyway. Could you add a small section in the README how and why we only can test the scripts locally. That would be great 👍

@ghost ghost added the size/XL label Sep 26, 2018
@AndreLouisCaron
Copy link
Contributor Author

Alright, removed appveyor.yml and added a few lines as requested. Feel free to rewrite that section as you see fit (after merging) :-)

@AndreLouisCaron AndreLouisCaron changed the title Add CI for Windows using AppVeyor Add support for running tests on Windows Sep 26, 2018
@mavogel mavogel self-requested a review September 28, 2018 14:17
@mavogel mavogel self-assigned this Sep 28, 2018
mavogel
mavogel approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@mavogel mavogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx 👍

@mavogel mavogel merged commit 064d2a9 into hashicorp:master Sep 28, 2018
@mavogel mavogel mentioned this pull request Sep 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mavogel mavogel mavogel approved these changes

Assignees

@mavogel mavogel

Labels
size/XL
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreLouisCaron @mavogel