terraform plan shows consul token provided via variable being

[amitsaha]

Hello, details follows. Summary is that when using consul_keys resource, the token which is provided
via -var to terraform plan, it shows the token in plain text.

Terraform Version

$ terraform -v
Terraform v0.11.7
+ provider.consul v1.0.0

Affected Resource(s)

• consul_keys

Terraform Configuration Files

variable "app1_version_token" {}           
                                           
resource "consul_keys" "app1_version" {    
  datacenter = "dc1"                       
  token = "${var.app1_version_token}"      
   key {                                   
    path  = "app1/version"                 
    value = "0.1"                          
  }                                        
}                                          

Debug Output

Not relevant

Panic Output

NA

Expected Behavior

Consul token marked "computed" or not shown at all.

Actual Behavior

consul_keys.app1_version: Creating...
  datacenter:             "" => "dc1"
  key.#:                  "" => "1"
  key.1209483366.default: "" => ""
  key.1209483366.delete:  "" => "false"
  key.1209483366.name:    "" => ""
  key.1209483366.path:    "" => "app1/version"
  key.1209483366.value:   "" => "0.1"
  token:                  "" => "cf0ed539-cb44-3a8b-17d0-f4dc03f47438"
  var.%:                  "" => "<computed>"

Steps to Reproduce

Run the following script:

#!/bin/bash
terraform_token="mysecret"
terraform apply -target=consul_keys.app1_version -var "app1_version_token=$terraform_token"

Important Factoids

References

[remilapeyre]

Hi @amitsaha, this is indeed an issue, the attached PR should fix the problem.